Skip to content

feat(key_manager): add filtering and asymmetric algos #4715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2025
Merged

feat(key_manager): add filtering and asymmetric algos #4715

merged 3 commits into from
May 15, 2025

Conversation

scaleway-bot
Copy link
Contributor

No description provided.

@scaleway-bot scaleway-bot requested a review from remyleone as a code owner May 13, 2025 14:16
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 55.25%. Comparing base (5bf53e0) to head (fdc7e33).
Report is 619 commits behind head on master.

Files with missing lines Patch % Lines
...namespaces/key_manager/v1alpha1/key_manager_cli.go 0.00% 13 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (fdc7e33). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (fdc7e33)
2 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #4715       +/-   ##
===========================================
- Coverage   75.45%   55.25%   -20.21%     
===========================================
  Files         202      312      +110     
  Lines       44323    79425    +35102     
===========================================
+ Hits        33444    43884    +10440     
- Misses       9653    34133    +24480     
- Partials     1226     1408      +182

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Laure-di Laure-di enabled auto-merge May 15, 2025 09:02
@Laure-di Laure-di added this pull request to the merge queue May 15, 2025
Merged via the queue into scaleway:master with commit f189ba3 May 15, 2025
14 checks passed
Laure-di added a commit to scaleway-bot/scaleway-cli that referenced this pull request May 15, 2025
@scaleway-bot @Laure-di
feat(key_manager): add filtering and asymmetric algos (scaleway#4715)
f76ae93 
Co-authored-by: Laure-di <lmasson@scaleway.com>
Co-authored-by: Laure-di <62625835+Laure-di@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

@Laure-di Laure-di Laure-di approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scaleway-bot @codecov-commenter @remyleone @Laure-di